fix: handle UNKNOWN code on syscall: 'stat'
#2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
added
topic: code
kittaakos
commented
Aug 18, 2023
arduino-ide-extension/src/test/node/sketches-service-impl.slow-test.ts
Outdated
Show resolved
Hide resolved
Closes #2166 Signed-off-by: Akos Kitta <[email protected]>
per1234
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
As I reported at #2166 (comment), I'm not able to reproduce #2166 so I can't verify that this fixes it. However, I am able to produce similar symptoms via different conditions (as described at the link above) and I did verify that this fixes that fault. I believe the fault I produced to be equivalent to that reported in #2166 so I will conclude that this should fix that one as well.
Thanks Akos!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IDE2 must gracefully handle when it cannot restore a sketch from a network drive at startup.
Change description
This PR relaxes the logic of how IDE2 checks whether a sketch is accessible. From now on,
UNKNOWNerrors are caught, and the missing sketch is not restored.Other information
Closes #2166
Reviewer checklist